[vlc] VideoLAN Ticket #3172 related bugs + your code mod

[Rémi Denis-Courmont]

	Hello,

Le lundi 11 janvier 2010 21:20:50 Michael, vous avez écrit :
> Apparently your fix had fixed that problem -> Cyrillic MP3 file names

I have no clue what you are on about. File names are stored in Unicode anyway 
(UTF-16 on Windows, UTF-8 on most Linux distros and MacOS). There hasn't been 
any change in VLC in that regards for years because it's been working fine.

The only recent changes has been in the handling of M3U playlists. Support for 
UTF-8 in M3U was removed in 1.0.3 and then reintroduced in 1.0.4 due to 
outcries from users. In 1.0.3 or when the file path is not valid UTF-8, VLC 
assumes ISO-8859-1 as normal. That said, I would recommend using .m3u8 for 
UTF-8 M3U playlists to avoid any confusion.

> and id3 tags in Win-1251 encoding (unicode/utf-8 is not popular and can
> be found only in new MP3 files)

There are no such thing as CP1251 and UTF-8 in (valid) ID3 tags.

> which is default for all MP3 files since day
>  1 and used on most platforms, but then because of some conflict situation
>  this fix has been removed, which results in non working Cyrillcs in MP3,
>  we get umlaut garbage.

The standard is quite clear that ID3 tags are either in ISO-8859-1 or in 
UTF-16. There is no way to indicate any other encoding, so there's no chance 
of VLC supporting CP1251 or any other Windows code page ever. It would be 
pointless since UTF-16 can carry any Cyrillic character unambiguously.

> Sadly I can't check this fix, since the working night build branch was
>  nicely killed by someone but many people confirm that it did help.
> 
> Any ways, the current 1.1.0 builds from 11-jan-10 still have this problem,
>  garbage names
> 
> And that means no Russian filenames on WinXP SP2 & SP3 (tested)
> 
> 1. Title bar text - garbage
> 2. Bottom of window - garbage
> 3. Play list - garbage
> 4. Goom scope - garbage
> 5. ID3 tag view/file info - garbage
> 
> Can you please look into it again and enable Ticket Bug - 3172

No. I believe your files are broken and VLC is correct.

> I have also noticed that during first start of VLC, preferably on a
> slow/heavy loaded PC it opens the MP3 file, shows Cyrillic/Russian file
> name in Title bar and bottom of screen properly! After 1-2 seconds just
> before it starts to play it the text is replaced by garbage!

That would happen if the engine preparses a file with broken IDv3 tags. First 
it has the Unicode path. Then, the file is preparsed. If the meta-data is 
formatted as ISO-8859-1 but encoding as CP1251, VLC will expectedly fail.
In other words, if your meta data are not encoded properly, VLC fails. There 
is not much to be done about that.

> And to check the active screen is easy - it's the screen where
> the mouse pointer is during start-up of VLC

As a matter of fact, the initial location of the VLC window is a matter for 
the window manager, not for VLC. To my knowledge, VLC only hints the location 
of the fullscreen video window. But even then, the window manager is 
responsible for putting the fullscreen window an a valid portion of the 
virtual desktop. So either way, it would seem that your window manager is 
buggy.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis