[vlmc-devel] commit: TracksView: Commenting out useless and buggy code. ( =?UTF-8?Q?Hugo=20Beauz=C3=A9e=2DLuyssen?==?UTF-8?Q?=20?=)

git at videolan.org git at videolan.org
Mon Dec 27 21:52:37 CET 2010


vlmc | branch: master | Hugo Beauzée-Luyssen <beauze.h at gmail.com> | Fri Dec  3 17:31:29 2010 +0100| [72b3e0dcad2aa21e2308b57ce8a8b06da40b7edb] | committer: Hugo Beauzée-Luyssen 

TracksView: Commenting out useless and buggy code.

This causes bug, and I can't find any reason to have this anymore.

> http://git.videolan.org/gitweb.cgi/vlmc.git/?a=commit;h=72b3e0dcad2aa21e2308b57ce8a8b06da40b7edb
---

 src/EffectsEngine/EffectUser.cpp |    2 +-
 src/Gui/timeline/TracksView.cpp  |   12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/EffectsEngine/EffectUser.cpp b/src/EffectsEngine/EffectUser.cpp
index 3b1c1ad..4d5e623 100644
--- a/src/EffectsEngine/EffectUser.cpp
+++ b/src/EffectsEngine/EffectUser.cpp
@@ -320,7 +320,7 @@ EffectUser::moveEffect( EffectHelper *helper, qint64 newPos )
             return ;
         }
     }
-    qWarning() << "Can't find effect" << helper->uuid();
+    qWarning() << this << "Can't find effect" << helper->uuid();
 }
 
 void
diff --git a/src/Gui/timeline/TracksView.cpp b/src/Gui/timeline/TracksView.cpp
index 89dd1a8..3b676a8 100644
--- a/src/Gui/timeline/TracksView.cpp
+++ b/src/Gui/timeline/TracksView.cpp
@@ -961,15 +961,15 @@ TracksView::mouseMoveEvent( QMouseEvent *event )
                     ClipHelper  *clipHelper = qobject_cast<ClipHelper*>( mediaItem->helper() );
                     Q_ASSERT( clipHelper != NULL );
                     m_effectTarget = mediaItem;
-                    effectItem->effectHelper()->setTarget( clipHelper->clipWorkflow() );
+//                    effectItem->effectHelper()->setTarget( clipHelper->clipWorkflow() );
                     break ;
                 }
             }
-            if ( m_effectTarget == NULL ) //Avoid doing this all the time.
-            {
-                GraphicsTrack *track = getTrack( m_actionItem->trackType(), m_actionItem->trackNumber() );
-                effectItem->effectHelper()->setTarget( track->trackWorkflow() );
-            }
+//            if ( m_effectTarget == NULL ) //Avoid doing this all the time.
+//            {
+//                GraphicsTrack *track = getTrack( m_actionItem->trackType(), m_actionItem->trackNumber() );
+//                effectItem->effectHelper()->setTarget( track->trackWorkflow() );
+//            }
         }
     }
     else if ( event->modifiers() == Qt::NoModifier &&



More information about the Vlmc-devel mailing list