[vlmc-devel] commit: Cleanup: Removing/Fixing old TODO and FIXME (Hugo Beauzee-Luyssen )

git at videolan.org git at videolan.org
Fri Mar 12 00:23:24 CET 2010


vlmc | branch: master | Hugo Beauzee-Luyssen <beauze.h at gmail.com> | Fri Mar 12 00:23:08 2010 +0100| [37f37d5d5c427069bf6f463a1e78c122becdaf15] | committer: Hugo Beauzee-Luyssen 

Cleanup: Removing/Fixing old TODO and FIXME

> http://git.videolan.org/gitweb.cgi/vlmc.git/?a=commit;h=37f37d5d5c427069bf6f463a1e78c122becdaf15
---

 src/Gui/MainWindow.cpp            |    3 ---
 src/Gui/library/MediaCellView.cpp |    2 --
 src/Project/ProjectManager.cpp    |    3 +--
 src/Workflow/AudioClipWorkflow.h  |    1 -
 src/Workflow/MainWorkflow.cpp     |    3 ---
 src/Workflow/TrackHandler.h       |    2 --
 6 files changed, 1 insertions(+), 13 deletions(-)

diff --git a/src/Gui/MainWindow.cpp b/src/Gui/MainWindow.cpp
index fe4a783..905617e 100644
--- a/src/Gui/MainWindow.cpp
+++ b/src/Gui/MainWindow.cpp
@@ -443,9 +443,6 @@ void    MainWindow::on_actionRender_triggered()
 
 void MainWindow::on_actionNew_Project_triggered()
 {
-    //TODO : clear the library, the timeline, and show the configuration box
-    //of the newly created project
-
     m_pWizard->restart();
     m_pWizard->show();
 }
diff --git a/src/Gui/library/MediaCellView.cpp b/src/Gui/library/MediaCellView.cpp
index 8280697..1ac8971 100644
--- a/src/Gui/library/MediaCellView.cpp
+++ b/src/Gui/library/MediaCellView.cpp
@@ -177,8 +177,6 @@ void    MediaCellView::mouseMoveEvent( QMouseEvent* event )
         return;
 
     QMimeData* mimeData = new QMimeData;
-    //FIXME the second argument is a media UUID instead of a Clip
-    // and this is not logical... but it works.
     mimeData->setData( "vlmc/uuid", m_clip->uuid().toString().toAscii() );
     QDrag* drag = new QDrag( this );
     drag->setMimeData( mimeData );
diff --git a/src/Project/ProjectManager.cpp b/src/Project/ProjectManager.cpp
index 9a72e46..935d157 100644
--- a/src/Project/ProjectManager.cpp
+++ b/src/Project/ProjectManager.cpp
@@ -220,8 +220,7 @@ void    ProjectManager::saveProject( bool saveAs /*= true*/ )
 void    ProjectManager::__saveProject( const QString &fileName )
 {
     QDomImplementation    implem = QDomDocument().implementation();
-    //FIXME: Think about naming the project...
-    QString name = "VLMCProject";
+    QString name = projectName();
     QString publicId = "-//XADECK//DTD Stone 1.0 //EN";
     QString systemId = "http://www-imagis.imag.fr/DTD/stone1.dtd";
     QDomDocument doc(implem.createDocumentType( name, publicId, systemId ) );
diff --git a/src/Workflow/AudioClipWorkflow.h b/src/Workflow/AudioClipWorkflow.h
index e8eb01e..7c62f92 100644
--- a/src/Workflow/AudioClipWorkflow.h
+++ b/src/Workflow/AudioClipWorkflow.h
@@ -79,7 +79,6 @@ class   AudioClipWorkflow : public ClipWorkflow
                                             quint32 bits_per_sample,
                                             quint32 size, qint64 pts );
 
-        //FIXME: this is totally random powered ! Please adjust with a value that does make sense...
         static const quint32   nbBuffers = 256;
 };
 
diff --git a/src/Workflow/MainWorkflow.cpp b/src/Workflow/MainWorkflow.cpp
index a7edc65..380ba98 100644
--- a/src/Workflow/MainWorkflow.cpp
+++ b/src/Workflow/MainWorkflow.cpp
@@ -65,9 +65,6 @@ MainWorkflow::MainWorkflow( int trackCount ) :
 
 MainWorkflow::~MainWorkflow()
 {
-    //FIXME: this is probably useless, since already done by the renderer
-    stop();
-
     delete m_effectEngine;
     delete m_renderStartedMutex;
     delete m_currentFrameLock;
diff --git a/src/Workflow/TrackHandler.h b/src/Workflow/TrackHandler.h
index 1032d6c..1784d0b 100644
--- a/src/Workflow/TrackHandler.h
+++ b/src/Workflow/TrackHandler.h
@@ -53,8 +53,6 @@ class   TrackHandler : public QObject
          *                              it's the same as currentFrame, but for an audio
          *                              track, it will be different.
          *  \param      paused          The renderer paused state
-         *  \todo       This should probably be partialy handled by the trackHandler, as the work
-         *              is exactly the same for both audio and video trackWorkflow in most of the case... or not.
          */
         void                    getOutput( qint64 currentFrame, qint64 subFrame,
                                            bool paused );



More information about the Vlmc-devel mailing list