[vlmc-devel] commit: TracksView: Fixing bad mouse releasing behaviour. ( Hugo Beauzée-Luyssen )

[Rohit Yadav]

Hi again Hugo,

-                    return ;
> +                    goto out;
>                 else if ( container == NULL && effectItem->startPos() ==
> effectItem->begin() )
> -                    return ;
> +                    goto out;
>                  m_actionItem->startPos() ==
> m_actionItem->track()->trackWorkflow()->getClipPosition(
> m_actionItem->uuid() ) )
> -                return ;
> +                goto out;
>
> +out:
>     m_action = TracksView::None;
>     //setDragMode( QGraphicsView::NoDrag );
>     QGraphicsView::mouseReleaseEvent( event );
>

Any good reason to use goto? Should n't we avoid labels? labels are bad...
Is that not possible by using a function or a #define or an inline if you
wish...?

Cheers,
Rohit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlmc-devel/attachments/20101130/0863223e/attachment.html>