[vlmc-devel] Patch for bug #436

Hugo Beauzée-Luyssen hugo at beauzee.fr
Thu May 7 15:24:43 CEST 2015


On Wed, May 6, 2015, at 08:44 PM, root-expert wrote:
> I just patched the bug #436. I prevent the user to enter special
> characters
> like !@#$ etc.
> I have included the .patch file.
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
> Email had 1 attachment:
> + GeneralPage-patch.patch
>   2k (text/x-patch)

Hi,

Thanks for your patch!
A few remarks:
- #436 is probably not the correct ticket number, I think you mean #455
- Please use spaces instead of tabs
- Try to keep an indentation consistent with the rest of the project
- I'd rephrase "You should not enter special characters!" into something
like "Please do not use special characters"
- [~!@#$%^&*()_-+=\/?><:;.'] is probably a bit too restrictive, at least
'_', '.' and '-' are perfectly legit :)

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the Vlmc-devel mailing list