[vlmc-devel] [PATCH] Fix "disconnect"

[yikei lu]

Sorry this patch does not fix the bug correctly. Please ignore it

2016-04-04 20:19 GMT+09:00 yikei lu <luyikei.qmltu at gmail.com>:
> Oh, sorry this is just copy of FIXME of what I fixed :) It was better
> to write FIX: FIXME for sure
>
> 2016-04-04 20:15 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>> Hi,
>>
>> On 04/04/2016 01:07 PM, Yikai Lu wrote:
>>>
>>> FIXME: metaDataComputed in Media class has no arguments, this shouldn't be
>>> working; replacing this with disconnect( media, &Media::metaDataComputed,
>>> this, &Library::mediaLoaded ); produces static_assert error
>>
>>
>> Do you mean that this patch causes a static_assert error?
>> Or that it fixes it?
>>
>>> ---
>>>   src/Library/Library.cpp | 7 +------
>>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> diff --git a/src/Library/Library.cpp b/src/Library/Library.cpp
>>> index db5e2bf..b7d0592 100644
>>> --- a/src/Library/Library.cpp
>>> +++ b/src/Library/Library.cpp
>>> @@ -113,13 +113,8 @@ void
>>>   Library::mediaLoaded( const Media* media )
>>>   {
>>>       if ( media != nullptr )
>>> -    {
>>> -        //FIXME: metaDataComputed in Media class has no arguments, this
>>> shouldn't be working;
>>> -        //replacing this with disconnect( media,
>>> &Media::metaDataComputed, this, &Library::mediaLoaded );
>>> -        //produces static_assert error
>>> -        disconnect( media, SIGNAL( metaDataComputed( const Media* ) ),
>>> +        disconnect( media, SIGNAL( metaDataComputed() ),
>>>                    this, SLOT( mediaLoaded( const Media* ) ) );
>>> -    }
>>>       if (m_nbMediaToLoad.fetchAndAddAcquire( -1 ) == 1)
>>>           emit projectLoaded();
>>>   }
>>>
>>
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel