[vlmc-devel] [PATCH 08/12] WorkflowFileRendererDialog: Remove unneeded arguments of renderVideo

[Hugo Beauzée-Luyssen]

Hi,

On 04/06/2016 12:28 PM, yikei lu wrote:
>>   the idea is to not rely on the project width/height/
> Do you mean the dialog or the renderer ?
>

Actually, both. The dialog should offer the project settings as the 
default value.
However, if the user chose some different value, we need to use those 
values for the rendering, without editing the project default.
The use case would be to have a test render with a different aspect 
ratio, a bigger resolution, ...


> 2016-04-06 18:19 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>> On 04/06/2016 09:58 AM, Yikai Lu wrote:
>>>
>>> ---
>>>    src/Gui/WorkflowFileRendererDialog.cpp | 6 +++---
>>>    src/Gui/WorkflowFileRendererDialog.h   | 2 +-
>>>    2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/src/Gui/WorkflowFileRendererDialog.cpp
>>> b/src/Gui/WorkflowFileRendererDialog.cpp
>>> index 151674f..ef44724 100644
>>> --- a/src/Gui/WorkflowFileRendererDialog.cpp
>>> +++ b/src/Gui/WorkflowFileRendererDialog.cpp
>>> @@ -29,9 +29,9 @@
>>>    #include "Workflow/MainWorkflow.h"
>>>    #include "Renderer/WorkflowRenderer.h"
>>>
>>> -WorkflowFileRendererDialog::WorkflowFileRendererDialog( quint32 width,
>>> quint32 height ) :
>>> -        m_width( width ),
>>> -        m_height( height ),
>>> +WorkflowFileRendererDialog::WorkflowFileRendererDialog() :
>>> +        m_width( Core::instance()->project()->width() ),
>>> +        m_height( Core::instance()->project()->height() ),
>>>            m_renderer( Core::instance()->workflowRenderer() )
>>>    {
>>>        m_ui.setupUi( this );
>>> diff --git a/src/Gui/WorkflowFileRendererDialog.h
>>> b/src/Gui/WorkflowFileRendererDialog.h
>>> index de46ee2..640b923 100644
>>> --- a/src/Gui/WorkflowFileRendererDialog.h
>>> +++ b/src/Gui/WorkflowFileRendererDialog.h
>>> @@ -33,7 +33,7 @@ class   WorkflowFileRendererDialog : public QDialog
>>>        Q_OBJECT
>>>        Q_DISABLE_COPY( WorkflowFileRendererDialog );
>>>    public:
>>> -    WorkflowFileRendererDialog( quint32 width, quint32 height );
>>> +    WorkflowFileRendererDialog();
>>>        void    setOutputFileName( const QString& filename );
>>>        void    setProgressBarValue( int val );
>>>
>>>
>>
>> That is probably unclear, and possibly inconsistent, but the idea is to not
>> rely on the project width/height/... and instead specify the settings for
>> each render.
>>
>> Regards,
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
>