[vlmc-devel] [PATCH 05/14] WorkflowRenderer: Mark WITH_GUI on Widget-related code

[Hugo Beauzée-Luyssen]

On 04/12/2016 01:47 PM, yikei lu wrote:
> That's achievable for sure! But I don't know when I'll start/finish it
> yet though
>
> 2016-04-12 20:45 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>> On 04/11/2016 08:09 AM, Yikai Lu wrote:
>>>
>>> ---
>>>    src/Renderer/WorkflowRenderer.cpp | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/src/Renderer/WorkflowRenderer.cpp
>>> b/src/Renderer/WorkflowRenderer.cpp
>>> index ea5a450..05be8de 100644
>>> --- a/src/Renderer/WorkflowRenderer.cpp
>>> +++ b/src/Renderer/WorkflowRenderer.cpp
>>> @@ -36,7 +36,9 @@
>>>    #include "Backend/IBackend.h"
>>>    #include "Backend/ISource.h"
>>>    #include "Workflow/MainWorkflow.h"
>>> +#ifdef WITH_GUI
>>>    #include "Gui/preview/RenderWidget.h"
>>> +#endif
>>>    #include "Settings/Settings.h"
>>>    #include "Tools/VlmcDebug.h"
>>>    #include "Workflow/Types.h"
>>> @@ -87,8 +89,10 @@ WorkflowRenderer::setupRenderer( quint32 width, quint32
>>> height, double fps, cons
>>>        m_sourceRenderer = m_source->createRenderer( m_eventWatcher );
>>>        m_sourceRenderer->setName( "WorkflowRenderer" );
>>>        m_sourceRenderer->enableMemoryInput( m_esHandler, getLockCallback(),
>>> getUnlockCallback() );
>>> +#ifdef WITH_GUI
>>>        if ( m_renderWidget != nullptr )
>>>            m_sourceRenderer->setOutputWidget( (void *) static_cast<
>>> RenderWidget* >( m_renderWidget )->id() );
>>> +#endif
>>>    }
>>>
>>>    int
>>>
>> I'd rather not apply this and address what we discussed regarding
>> introducing a new IRenderer (or a different name) to handle multiple
>> rendering targets (http, file, widget so far)
>> Do you think that's achievable?
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
>
There is no rush (yet :p)