[vlmc-devel] [PATCH 08/14] ConsoleRenderer: Use Project's video settings

[Hugo Beauzée-Luyssen]

On 04/11/2016 08:09 AM, Yikai Lu wrote:
> ---
>   src/Renderer/ConsoleRenderer.cpp | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/Renderer/ConsoleRenderer.cpp b/src/Renderer/ConsoleRenderer.cpp
> index 275d4ed..48858fc 100644
> --- a/src/Renderer/ConsoleRenderer.cpp
> +++ b/src/Renderer/ConsoleRenderer.cpp
> @@ -23,7 +23,7 @@
>   #include "ConsoleRenderer.h"
>
>   #include "WorkflowFileRenderer.h"
> -#include "SettingsManager.h"
> +#include "Project/Project.h"
>
>   #include <QCoreApplication>
>   #include <QStringList>
> @@ -34,11 +34,11 @@ ConsoleRenderer::ConsoleRenderer(QObject *parent) :
>       m_renderer = new WorkflowFileRenderer;
>       m_renderer->initializeRenderer();
>       m_outputFileName = qApp->arguments()[2];
> -    m_width = VLMC_PROJECT_GET_UINT( "video/VideoProjectWidth" );
> -    m_height = VLMC_PROJECT_GET_UINT( "video/VideoProjectHeight" );
> -    m_fps = VLMC_PROJECT_GET_DOUBLE( "video/VLMCOutputFPS" );
> -    m_vbitrate = 4000;
> -    m_abitrate = 256;
> +    m_width = Core::instance()->project()->width();
> +    m_height = Core::instance()->project()->height();
> +    m_fps = Core::instance()->project()->fps();
> +    m_vbitrate = Core::instance()->project()->videoBitrate();
> +    m_abitrate = Core::instance()->project()->audioBitrate();
>       connect( m_renderer, SIGNAL( frameChanged( qint64 ) ),
>                this, SLOT( frameChanged( qint64 ) ) );
>       connect( m_renderer, SIGNAL( renderComplete() ), qApp, SLOT( quit() ) );
>
LGTM
What seems weird is that we don't have a nbChannels/samplerate member 
variable :/