[vlmc-devel] [PATCH 09/14] ConsoleRenderer: Remember aspectRatio

[Hugo Beauzée-Luyssen]

On 04/12/2016 02:15 PM, yikei lu wrote:
> The problem is currently we use fixed values of them in WorkflowRenderer...
>
>      , m_nbChannels( 2 )
>      , m_rate( 48000 )
>
> And no setters. If there is no problem, I'll create them.
>
> 2016-04-12 21:11 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>> On 04/11/2016 08:09 AM, Yikai Lu wrote:
>>>
>>> ---
>>>    src/Renderer/ConsoleRenderer.cpp | 1 +
>>>    src/Renderer/ConsoleRenderer.h   | 1 +
>>>    2 files changed, 2 insertions(+)
>>>
>>> diff --git a/src/Renderer/ConsoleRenderer.cpp
>>> b/src/Renderer/ConsoleRenderer.cpp
>>> index 48858fc..fb7724e 100644
>>> --- a/src/Renderer/ConsoleRenderer.cpp
>>> +++ b/src/Renderer/ConsoleRenderer.cpp
>>> @@ -37,6 +37,7 @@ ConsoleRenderer::ConsoleRenderer(QObject *parent) :
>>>        m_width = Core::instance()->project()->width();
>>>        m_height = Core::instance()->project()->height();
>>>        m_fps = Core::instance()->project()->fps();
>>> +    m_ar = Core::instance()->project()->aspectRatio();
>>>        m_vbitrate = Core::instance()->project()->videoBitrate();
>>>        m_abitrate = Core::instance()->project()->audioBitrate();
>>>        connect( m_renderer, SIGNAL( frameChanged( qint64 ) ),
>>> diff --git a/src/Renderer/ConsoleRenderer.h
>>> b/src/Renderer/ConsoleRenderer.h
>>> index 2db770b..5b3c9cb 100644
>>> --- a/src/Renderer/ConsoleRenderer.h
>>> +++ b/src/Renderer/ConsoleRenderer.h
>>> @@ -49,6 +49,7 @@ private:
>>>        double                  m_fps;
>>>        quint32                 m_vbitrate;
>>>        quint32                 m_abitrate;
>>> +    QString                 m_ar;
>>>    };
>>>
>>>    #endif // CONSOLERENDERER_H
>>>
>> Oh well I forgot to mention the aspect ratio in the previous patch review :)
>> Could you add nbChannels & audio sample rate to this patch?
>>
>> Regards,
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
>
I think the only problem here is my laziness when I wrote the initial 
implementation :'(