[vlmc-devel] [PATCH 4/5] RenderTarget: Widget

[Hugo Beauzée-Luyssen]

On 04/14/2016 10:10 AM, Yikai Lu wrote:
> ---
>   src/Backend/Target/WidgetTarget.cpp | 17 +++++++++++++++++
>   src/Backend/Target/WidgetTarget.h   | 18 ++++++++++++++++++
>   src/CMakeLists.txt                  |  1 +
>   3 files changed, 36 insertions(+)
>   create mode 100644 src/Backend/Target/WidgetTarget.cpp
>   create mode 100644 src/Backend/Target/WidgetTarget.h
>
> diff --git a/src/Backend/Target/WidgetTarget.cpp b/src/Backend/Target/WidgetTarget.cpp
> new file mode 100644
> index 0000000..d0cd734
> --- /dev/null
> +++ b/src/Backend/Target/WidgetTarget.cpp
> @@ -0,0 +1,17 @@
> +#include "WidgetTarget.h"
> +
> +#include "Backend/ISourceRenderer.h"
> +
> +using namespace Backend;
> +
> +WidgetTarget::WidgetTarget( void* id )
> +    : m_id( id )
> +{
> +}
> +
> +void
> +WidgetTarget::configure( ISourceRenderer *renderer )
> +{
> +    renderer->setOutputWidget( m_id );
> +}
> +
> diff --git a/src/Backend/Target/WidgetTarget.h b/src/Backend/Target/WidgetTarget.h
> new file mode 100644
> index 0000000..7605ff4
> --- /dev/null
> +++ b/src/Backend/Target/WidgetTarget.h
> @@ -0,0 +1,18 @@
> +#ifndef WIDGETTARGET_H
> +#define WIDGETTARGET_H
> +
> +#include "Backend/IRenderTarget.h"
> +
> +namespace Backend
> +{
> +    class WidgetTarget : public IRenderTarget
> +    {
> +    public:
> +        WidgetTarget( void* id );
> +        virtual void configure( ISourceRenderer *renderer );

Please add the override qualifier for new code

> +    private:
> +        void* m_id;
> +    };
> +}
> +
> +#endif // WIDGETTARGET_H
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
> index ae426ff..4c59e63 100644
> --- a/src/CMakeLists.txt
> +++ b/src/CMakeLists.txt
> @@ -46,6 +46,7 @@ SET(VLMC_SRCS
>       Backend/VLC/VLCVmemRenderer.cpp
>       Backend/VLC/VLCSource.cpp
>       Backend/VLC/VLCMemorySource.cpp
> +    Backend/Target/WidgetTarget.cpp
>       EffectsEngine/EffectsEngine.cpp
>       EffectsEngine/Effect.cpp
>       EffectsEngine/EffectUser.cpp
>

Apparently this commit is replaced by a new one, so I'll comment more on 
the other one