[vlmc-devel] Timeline, Workflow: Introduce shared_ptr to handle IService::filter(), EffectHelper and Clip

Yikai Lu git at videolan.org
Mon Jul 4 15:34:21 CEST 2016


vlmc | branch: medialibrary | Yikai Lu <luyikei.qmltu at gmail.com> | Mon Jun 27 16:37:41 2016 +0900| [4ecbe7b67bafeb2570da94e45668daf5180851ca] | committer: Yikai Lu

Timeline, Workflow: Introduce shared_ptr to handle IService::filter(), EffectHelper and Clip

Sorry that this commit is big, but in order not to break building and not to make more bugs, those changes should be made.

But Good News! Many segfaults are fixed by this commit. Especially ones caused by redo/undo are mostly fixed.

> https://code.videolan.org/videolan/vlmc/commit/4ecbe7b67bafeb2570da94e45668daf5180851ca
---

 src/Backend/IService.h                            |  3 +-
 src/Backend/MLT/MLTService.cpp                    |  4 +-
 src/Backend/MLT/MLTService.h                      |  2 +-
 src/Commands/Commands.cpp                         | 42 +++++++--------
 src/Commands/Commands.h                           | 36 +++++++------
 src/EffectsEngine/EffectHelper.cpp                | 12 ++---
 src/EffectsEngine/EffectHelper.h                  |  9 ++--
 src/Gui/effectsengine/EffectInstanceListModel.cpp |  2 +-
 src/Gui/effectsengine/EffectInstanceWidget.cpp    | 13 ++---
 src/Gui/effectsengine/EffectInstanceWidget.h      |  6 +--
 src/Gui/effectsengine/EffectStack.cpp             |  4 +-
 src/Gui/timeline/AbstractGraphicsItem.h           |  4 +-
 src/Gui/timeline/AbstractGraphicsMediaItem.cpp    | 21 +++-----
 src/Gui/timeline/AbstractGraphicsMediaItem.h      | 13 ++---
 src/Gui/timeline/GraphicsAudioItem.cpp            |  6 +--
 src/Gui/timeline/GraphicsAudioItem.h              |  2 +-
 src/Gui/timeline/GraphicsEffectItem.cpp           | 22 ++++----
 src/Gui/timeline/GraphicsEffectItem.h             | 11 ++--
 src/Gui/timeline/GraphicsMovieItem.cpp            |  6 +--
 src/Gui/timeline/GraphicsMovieItem.h              |  2 +-
 src/Gui/timeline/TracksScene.cpp                  | 10 ++--
 src/Gui/timeline/TracksView.cpp                   | 64 +++++++----------------
 src/Gui/timeline/TracksView.h                     |  9 +---
 src/Workflow/MainWorkflow.cpp                     | 16 ++----
 src/Workflow/MainWorkflow.h                       | 12 ++---
 src/Workflow/TrackWorkflow.cpp                    |  8 +--
 src/Workflow/TrackWorkflow.h                      | 14 ++---
 27 files changed, 153 insertions(+), 200 deletions(-)

Diff:   https://code.videolan.org/videolan/vlmc/commit/4ecbe7b67bafeb2570da94e45668daf5180851ca


More information about the Vlmc-devel mailing list