[vlmc-devel] [PATCH] CMakeLists: Use LIBVLC_LIBRARY_DIRS on OS X

[Paweł Goliński]

> Wiadomość napisana przez Paweł Goliński <golpaw1 at gmail.com> w dniu 31.07.2016, o godz. 17:50:
> 
> 
>> Wiadomość napisana przez Hugo Beauzée-Luyssen <hugo at beauzee.fr> w dniu 31.07.2016, o godz. 17:38:
>> 
>> On 07/29/2016 07:05 PM, Paweł Goliński wrote:
>>> Please merge this!
>>> 
>>>> Wiadomość napisana przez Pawel Golinski <golpaw1 at gmail.com> w dniu 20.07.2016, o godz. 22:45:
>>>> 
>>>> ---
>>>> src/CMakeLists.txt | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>> 
>>>> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>>>> index a85cf0a..7b37f38 100644
>>>> --- a/src/CMakeLists.txt
>>>> +++ b/src/CMakeLists.txt
>>>> @@ -314,14 +314,14 @@ ENDIF(UNIX)
>>>> 
>>>> if( APPLE )
>>>>   set(APPLICATION_BUNDLE ${CMAKE_BINARY_DIR}/bin/vlmc.app)
>>>> -    set(APPLICATION_LIB_DIR ${LIBVLC_LIB_DIR})
>>>> +    set(APPLICATION_LIB_DIR ${LIBVLC_LIBRARY_DIRS})
>>>> 
>>>>   # re-enable this when we start addressing redistribution
>>>>   # message(STATUS "Looking for bundle ${APPLICATION_BUNDLE} with library path ${APPLICATION_LIB_DIR}")
>>>>   # install(CODE "include(BundleUtilities)
>>>>   add_custom_command(TARGET vlmc
>>>>       POST_BUILD
>>>> -        COMMAND ${CMAKE_SOURCE_DIR}/cmake/FixBundle.sh ${APPLICATION_BUNDLE}/Contents/MacOS ${LIBVLC_LIB_DIR}
>>>> +        COMMAND ${CMAKE_SOURCE_DIR}/cmake/FixBundle.sh ${APPLICATION_BUNDLE}/Contents/MacOS ${LIBVLC_LIBRARY_DIRS}
>>>>       COMMENT "Fixing application bundle for local run")
>>>>   # fixup_bundle(\"${APPLICATION_BUNDLE}\" \"\" \"${APPLICATION_LIB_DIR}\")" COMPONENT Runtime)
>>>> endif()
>>>> -- 
>>>> 2.7.4 (Apple Git-66)
>>>> 
>>> 
>>> _______________________________________________
>>> Vlmc-devel mailing list
>>> Vlmc-devel at videolan.org
>>> https://mailman.videolan.org/listinfo/vlmc-devel
>>> 
>> 
>> Thanks for fixing the cmake buildsystem, however the reason I was
>> reluctant at merging this is because I'd like to have the autotools
>> branch merged to master.
>> Speaking of which, did you have a chance to try it out on macOS?
> 
> Yeah, I wrote about it on IRC.
> 
> I did „git pull origin autotools”, then „./configure”.
> 
> And I still get same error:
> ./configure: line 3353: syntax error near unexpected token `noext'
> ./configure: line 3353: `AX_CXX_COMPILE_STDCXX_11(noext)’

Ok, I needed to do „autoreconf -f” too.

After that (and a few fights with pkgconfig + PKG_CONFIG_PATH adjusting), I got to build stage.

Building VLMC fails though, with:

"In file included from src/Workflow/TrackWorkflow.moc.cpp:9:
In file included from src/Workflow/TrackWorkflow.h:35:
./src/Media/Clip.h:102:30: warning: 'uuid' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        const QUuid         &uuid() const;
                             ^
./src/Workflow/Helper.h:41:37: note: overridden virtual function is here
            virtual const QUuid&    uuid() const;
                                    ^
1 warning generated.
  CXX      src/Services/YouTube/vlmc-YouTubeService.moc.o
src/Services/YouTube/YouTubeService.moc.cpp:84:21: error: no member named 'sslErrors' in 'YouTubeService'
        case 2: _t->sslErrors((*reinterpret_cast< QNetworkReply*(*)>(_a[1])),(*reinterpret_cast< const QList<QSslError>(*)>(_a[2]))); break;
                ~~  ^
1 error generated.
make[1]: *** [src/Services/YouTube/vlmc-YouTubeService.moc.o] Error 1
make: *** [all] Error 2”


> 
>> 
>> Regards,
>> 
>> -- 
>> Hugo Beauzée-Luyssen
>> www.beauzee.fr
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
>