[vlmc-devel] [PATCH] Make toolbar unmovable

Paweł Goliński golpaw1 at gmail.com
Mon Mar 7 13:45:23 CET 2016 

Yes, the toolbar is the only widget affected. I can move it however if I disable all
widget initialization in MainWindow.cpp, but I haven’t looked much beyond that yet.

AFAIC, only I was able to reproduce this issue, from the stack trace it seems OS X specific.

> Wiadomość napisana przez Hugo Beauzée-Luyssen <hugo at beauzee.fr> w dniu 07.03.2016, o godz. 13:40:
> 
> On 03/07/2016 10:51 AM, Paweł Goliński wrote:
>> Here is how to reproduce it:
>> https://www.youtube.com/watch?v=fhvy2AehYQ8&feature=em-upload_owner
>> 
>> I know this doesn’t make a good fix, but it’s a workaround (do the users
>> really move the toolbar that
>> frequently? Either way if they move it, they’ve just lost their entire
>> work) until this is properly fixed.
>> 
>> Here’s the stacktrace: http://pastebin.com/Sr3wDw47 (I don’t know if the
>> crashhandler was disabled, but in CMakeLists.txt there is
>> this fragment of code:
>> "IF(NOT APPLE)
>>     SET(WITH_CRASHHANDLER_GUI TRUE CACHE BOOL "Enable the crash handler
>> GUI (with backtrace and restart capabilities)")
>>     SET(WITH_CRASHHANDLER TRUE CACHE BOOL "Enable the crash handler")
>> ELSE(NOT APPLE)
>>     #FIXME: Mac OS port does n't start if crash handler is enabled.
>>     SET(WITH_CRASHHANDLER_GUI FALSE CACHE BOOL "Disable crash handler
>> gui...")
>>     SET(WITH_CRASHHANDLER False CACHE BOOL "Disable the crash handler")
>>     #SET(CMAKE_OSX_ARCHITECTURES i386)
>>     #SET(CMAKE_INSTALL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}")
>> ENDIF(NOT APPLE)”
>> That suggests it is defaultly disabled…)
>> 
>>> Wiadomość napisana przez Hugo Beauzée-Luyssen <hugo at beauzee.fr
>>> <mailto:hugo at beauzee.fr>> w dniu 07.03.2016, o godz. 09:57:
>>> 
>>> On 03/07/2016 03:21 AM, Paweł Goliński wrote:
>>>> When user tried to move toolbar, VLMC crashed with
>>>> segmentation fault. This patch made toolbar unmovable,
>>>> which solves the problem.
>>>> ---
>>>> src/Gui/ui/MainWindow.ui | 31 ++++++++++++++++++++-----------
>>>> 1 file changed, 20 insertions(+), 11 deletions(-)
>>>> 
>>>> diff --git a/src/Gui/ui/MainWindow.ui b/src/Gui/ui/MainWindow.ui
>>>> index 4640741..c8f1465 100644
>>>> --- a/src/Gui/ui/MainWindow.ui
>>>> +++ b/src/Gui/ui/MainWindow.ui
>>>> @@ -27,7 +27,7 @@
>>>>      <x>0</x>
>>>>      <y>0</y>
>>>>      <width>800</width>
>>>> -     <height>17</height>
>>>> +     <height>22</height>
>>>>     </rect>
>>>>    </property>
>>>>    <widget class="QMenu" name="menuEdit">
>>>> @@ -99,6 +99,15 @@
>>>>    <property name="windowTitle">
>>>>     <string>VLMC Toolbar</string>
>>>>    </property>
>>>> +   <property name="movable">
>>>> +    <bool>false</bool>
>>>> +   </property>
>>>> +   <property name="allowedAreas">
>>>> +    <set>Qt::TopToolBarArea</set>
>>>> +   </property>
>>>> +   <property name="floatable">
>>>> +    <bool>false</bool>
>>>> +   </property>
>>>>    <attribute name="toolBarArea">
>>>>     <enum>TopToolBarArea</enum>
>>>>    </attribute>
>>>> @@ -151,7 +160,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Project Preferences</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionPreview">
>>>>    <property name="checkable">
>>>> @@ -189,7 +198,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Makes VLMC Fullscreen</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionRender">
>>>>    <property name="icon">
>>>> @@ -216,7 +225,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Loads a VLMC Project</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionSave">
>>>>    <property name="icon">
>>>> @@ -228,7 +237,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Saves a VLMC Project</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionImport">
>>>>    <property name="icon">
>>>> @@ -252,7 +261,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Project Preferences</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionSave_As">
>>>>    <property name="icon">
>>>> @@ -264,7 +273,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Save a VLMC project as a different name</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionClose_Project">
>>>>    <property name="icon">
>>>> @@ -276,7 +285,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Closes a VLMC project</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionCrash">
>>>>    <property name="text">
>>>> @@ -293,7 +302,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Undoes the previous action</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionRedo">
>>>>    <property name="icon">
>>>> @@ -305,7 +314,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Redoes the previous action</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>   <action name="actionShare_On_Internet">
>>>>    <property name="icon">
>>>> @@ -362,7 +371,7 @@
>>>>    </property>
>>>>    <property name="statusTip">
>>>>     <string>Use the Scissor Tool to cut regions in the timeline</string>
>>>> -  </property>
>>>> +   </property>
>>>>   </action>
>>>>  </widget>
>>>>  <resources>
>>>> 
>>> 
>>> Hi,
>>> 
>>> I can't reproduce the issue, but this would not be the proper fix
>>> anyway, unless the crash lies in Qt for some reason.
>>> Do you have a backtrace?
>>> 
>>> (Remember that to get a usable backtrace, VLMC needs to be built
>>> without the crash handler)
>>> 
>>> Regards,
>>> _______________________________________________
>>> Vlmc-devel mailing list
>>> Vlmc-devel at videolan.org <mailto:Vlmc-devel at videolan.org>
>>> https://mailman.videolan.org/listinfo/vlmc-devel
>> 
>> 
>> 
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
>> 
> 
> This definitely looks like a platform specific issue to me... could you check if some other people can reproduce a similar issue with docked widgets?
> 
> Is the toolbar the only widget that makes the application crash when you move it?
> 
> Regards,
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel

More information about the Vlmc-devel mailing list