[vlmc-devel] [PATCH 1/3] Fix indention of SettingValue *pName

[yikei lu]

sorry I forgot it

2016-03-08 21:03 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
> On 03/08/2016 06:17 AM, Yikai Lu wrote:
>>
>> I fix this by creating a proxy slot.
>> ---
>>   src/Project/Project.cpp | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/Project/Project.cpp b/src/Project/Project.cpp
>> index 6c36d83..fc9fda5 100644
>> --- a/src/Project/Project.cpp
>> +++ b/src/Project/Project.cpp
>> @@ -212,9 +212,9 @@ Project::initSettings()
>>
>> QT_TRANSLATE_NOOP("PreferenceWidget", "Number of audio channels" ),
>>
>> SettingValue::Clamped );
>>       audioChannel->setLimits( 2, 2 );
>> -       SettingValue* pName = m_settings->createVar( SettingValue::String,
>> "vlmc/ProjectName", unNamedProject,
>> -
>> QT_TRANSLATE_NOOP( "PreferenceWidget", "Project name" ),
>> -
>> QT_TRANSLATE_NOOP( "PreferenceWidget", "The project name" ),
>> +    SettingValue    *pName = m_settings->createVar( SettingValue::String,
>> "vlmc/ProjectName", unNamedProject,
>> +                                    QT_TRANSLATE_NOOP(
>> "PreferenceWidget", "Project name" ),
>> +                                    QT_TRANSLATE_NOOP(
>> "PreferenceWidget", "The project name" ),
>>                                       SettingValue::NotEmpty );
>>       connect( pName, SIGNAL( changed( QVariant ) ), this, SIGNAL(
>> projectUpdated( QVariant ) ) );
>>   }
>>
>
> Applied the 3 of them.
> I manually edited the patch to fix a minor coding style issue: we put the
> return type on its specific line, so for instance, instead of
>
> void Project::projectUpdated(const QVariant &projectName)
>
> it should be
>
> void
> Project::projectUpdated(const QVariant &projectName)
>
>
> Thanks!
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel