[vlmc-devel] [PATCH] validate data in settings file

[Hugo Beauzée-Luyssen]

On 03/08/2016 01:56 PM, sanket.markan wrote:
> validated data in settings file.
>
>
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
>

Hi,

Please create a new thread for your further patches, it gets difficult 
to track otherwise.

This patch breaks the (already fairly poor) UI/backend separation.
We don't want to depend on QtGui from the Settings class.
Moreover, I stand by the assert.
Except when the settings are restored after a change in the code that 
removed an old settings, this assert will either fire when a setting is 
loaded too early, or when the developer made a typo in the variable name.

Not asserting when we are restoring the settings could be an option, but 
this patch is definitely rejected.

Regards,