[vlmc-devel] PATCH [Restores default settings on project close]

[Hugo Beauzée-Luyssen]

On 03/08/2016 04:37 PM, Barun Parruck wrote:
> Fixed a //FIX ME , on project close settings will now be restored to
> their default values.
>
> --
> This is my Footrr <https://footrr.com/7131.html>
>
>
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
>

Hi,

A few comments:
- This missed a lock on the settings mutex
- If you return during your for loop, chances are only one setting will 
be restored ;)
- I'd suggest using a range-based for loop to improve clarity and 
conciseness

Regards,