[vlmc-devel] [PATCH] backup when vlmc closes unexpectedly

[Hugo Beauzée-Luyssen]

On 03/11/2016 07:20 PM, sanket.markan wrote:
> fixed a FIXME in mainwindow.cpp
> 
> 
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
> 

Hi,

I don't like the idea of exposing a flag publicly.

Also, I don't get why you're calling emergencyBackup() from
Project::autoSaveRequired()
Granted, it feels weird to have two ways of creating a backup file,
though the project class is not exactly in a good shape right now.

The general idea was that:
- if a backup file is found, it will be loaded, the
backupProjectLoaded() signal will be emited
- if VLMC crashes, it will try its best to save the project and set the
EmergencyBackup setting to the backup path
- There is an autosave functionnality that will create a backup file
every N minutes, depending on the setting.

Restoring the backup from the Project class was previously done by
asking the user directly from the Project class, but that breaks the
separation between UI & Core components.

I'm not sure it's usefull to have 2 ways of restoring a session. I don't
see the difference between restoring an automatic backup and restoring
an "emergency backup". Probably this code should be merged first.


-- 
Hugo Beauzée-Luyssen
www.beauzee.fr