[vlmc-devel] [PATCH 2/2] Resolved PLAY button icon change issue

[Hugo Beauzée-Luyssen]

On 03/13/2016 10:32 AM, Abhimanyu Singh Gaur wrote:
> Earlier the PLAY button icon in project preview didn't used to change back to play from pause, if we paused the media, because the media was not actually getting paused. So no signal for pause was emitted. Now it works fine with this patch.
> ---
>  src/Gui/preview/PreviewWidget.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/Gui/preview/PreviewWidget.cpp b/src/Gui/preview/PreviewWidget.cpp
> index f5bc00b..d0975dd 100644
> --- a/src/Gui/preview/PreviewWidget.cpp
> +++ b/src/Gui/preview/PreviewWidget.cpp
> @@ -129,6 +129,13 @@ PreviewWidget::on_pushButtonPlay_clicked()
>      if ( m_previewStopped == true )
>          m_previewStopped = false;
>      m_renderer->togglePlayPause();
> +    if ( m_renderer->isRendering() )
> +    {
> +        if( m_renderer->isPaused() )
> +            m_ui->pushButtonPlay->setIcon( QIcon( ":/images/play" ) );
> +        else
> +            m_ui->pushButtonPlay->setIcon( QIcon( ":/images/pause" ) );
> +    }
>  }
>  
>  void
> 

That's an issue that needs to be fixed in the WorkflowRenderer rather
than the preview widget.
It is true that the WorkflowRenderer will not actually pause its media
player, but that's an implementation detail that shouldn't leak up to
the UI.

-- 
Hugo Beauzée-Luyssen
www.beauzee.fr