[vlmc-devel] Timeline: Save markers to the project

[yikei lu]

On Thu, Jul 13, 2017 at 5:23 PM, Hugo Beauzée-Luyssen <hugo at beauzee.fr> wrote:
> On Sat, Jul 8, 2017, at 05:16 PM, Yikai Lu wrote:
>> vlmc | branch: master | Yikai Lu <luyikei.qmltu at gmail.com> | Fri Jul  7
>> 18:58:13 2017 +0900| [51913b5971bd95b331530a9d0b6b8851e26e6c43] |
>> committer: Yikai Lu
>>
>> Timeline: Save markers to the project
>>
>> > https://code.videolan.org/videolan/vlmc/commit/51913b5971bd95b331530a9d0b6b8851e26e6c43
>> ---
>>
>>  Makefile.am                            |  2 +
>>  src/Commands/Commands.cpp              | 83
>>  +++++++++++++++++++++++++++++++++
>>  src/Commands/Commands.h                | 50 ++++++++++++++++++++
>>  src/Gui/MainWindow.cpp                 |  2 +-
>>  src/Gui/timeline/Marker.qml            | 24 +++++++++-
>>  src/Gui/timeline/MarkerContextMenu.qml |  2 +-
>>  src/Gui/timeline/MarkerManager.cpp     | 84
>>  ++++++++++++++++++++++++++++++++++
>>  src/Gui/timeline/MarkerManager.h       | 52 +++++++++++++++++++++
>>  src/Gui/timeline/Ruler.qml             |  2 +-
>>  src/Gui/timeline/Timeline.cpp          | 49 +++++++++++++++++++-
>>  src/Gui/timeline/Timeline.h            | 23 +++++++++-
>>  src/Gui/timeline/main.qml              | 10 ++++
>>  12 files changed, 377 insertions(+), 6 deletions(-)
>>
>> Diff:
>> https://code.videolan.org/videolan/vlmc/commit/51913b5971bd95b331530a9d0b6b8851e26e6c43
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
>
> MarkerManager.cpp misses an include to config.h
> Also, nitpicking, but the constructor isn't required

Should we include confing.h all the time?

>
> --
>   Hugo Beauzée-Luyssen
>   hugo at beauzee.fr
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel