[vlmc-devel] [PATCH] WelcomePage: Add QMessageBox noticing user when project file is not found

[yikei lu]

On Sun, Mar 12, 2017 at 11:12 PM, yikei lu <luyikei.qmltu at gmail.com> wrote:
> Looks good to me! I'm going to test this, and if it's fine, I'll apply it!
>
> One last thing that I should tell you is that you should put spaces
> between parentheses and quotation marks. But I'm going to fix it by
> myself since you've already been fixing this patch :)
>
> On Sun, Mar 12, 2017 at 11:03 PM, Hieu Pham <phamhuuquanghieu at gmail.com> wrote:
>> ---
>>  src/Gui/wizard/WelcomePage.cpp | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/src/Gui/wizard/WelcomePage.cpp b/src/Gui/wizard/WelcomePage.cpp
>> index 0b95dc1..6bbcbff 100644
>> --- a/src/Gui/wizard/WelcomePage.cpp
>> +++ b/src/Gui/wizard/WelcomePage.cpp
>> @@ -106,6 +106,13 @@ WelcomePage::validatePage()
>>                                        "the list.\nThen click next to continue..." ) );
>>              return false;
>>          }
>> +        else if ( QFile::exists( *m_projectPath ) == false )
>> +        {
>> +            QMessageBox::warning( this, tr("Warning"),
>> +                                  tr( "Sorry, we couldn't find your file. Was it moved, renamed, or deleted?" )
>> +                                  + "\n" + m_projectPath->toUtf8());

Sorry, one more thing. You could've used QString::arg for formatting strings.

>> +            return false;
>> +        }
>>          return true;
>>      }
>>      return true;
>> --
>> 2.9.3
>>
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel