[x264-devel] Re: [MOD] [PATCH] Rate control

[Måns Rullgård]

Laurent Aimar <fenrir at via.ecp.fr> writes:

>> From: Måns Rullgård <mru at mru.ath.cx>
>> Date: Fri, 06 Aug 2004 13:49:38 +0200
>> To: x264-devel at videolan.org
>> Subject: [PATCH] Rate control
>> 
>> Here's a patch that adds some kind of rate control.  I suppose it is
>> by no means perfect, but it's much better than constant quantizer.  It
>> also has a very crude scene change detection that sometimes avoids a
>> buffer underflow by reencoding oversized P/B frames as I frames.
>> 
>> Please let me know if I've done something bad and I'll try to change
>> it.
>
>  I have applied it to SVN. Thanks for the patch :)))
>
>  I have only changed a few tabs into spaces,

OK, I'll make emacs produce spaces instead from now on.  Are there
other coding style rules I should try to follow?

I also noticed you'd changed the utf8 into iso-8859-1.

> and fixed a bit the P -> I reencode.  (It needs more testing to be
> sure it doesn't break the bitstream).

I figured something like that would be needed, but I wasn't quite sure
of the details.

>  It seems to work pretty well :) but from my (really too) limited tests,
> it seems to always produce lower bitrate than requested (semething like
> 5-7%).

I'll have a look at that.  What frame sizes and bitrates have you
tried?  Do you have any particularly evil test sequences?

-- 
Måns Rullgård
mru at mru.ath.cx

-- 
This is the x264-devel mailing-list
If you are in trouble, please contact <postmaster at videolan.org>