[x264-devel] Re: [MOD] [PATCH] Rate control

[Måns Rullgård]

Loren Merritt <lorenm at u.washington.edu> writes:

> On Sun, 8 Aug 2004, [iso-8859-1] Måns Rullgård wrote:
>
>> Laurent Aimar <fenrir at via.ecp.fr> writes:
>>
>> >  It seems to work pretty well :) but from my (really too) limited tests,
>> > it seems to always produce lower bitrate than requested (semething like
>> > 5-7%).
>>
>> Which number did you look at?  The rate printed by x264_encoder_close
>> is always a bit lower than the actual file size.  Which of these
>> should be the target?
>
> I noticed that the rate printed by x264 was always less than the rate
> printed by mencoder (which was equal to my requested bitrate). Then I
> noticed that my requested bitrate was in k=1000 while the reported
> rate was in k=1024.

OK, so my rate control is working after all?  For bitrates I think
traditionally 1k is considered to be equal to 1000, as your patch
changes the output to.  I'll leave it to Laurent to decide what to do
with the patch though.

-- 
Måns Rullgård
mru at mru.ath.cx

-- 
This is the x264-devel mailing-list
If you are in trouble, please contact <postmaster at videolan.org>