[x264-devel] Re: x264: svn commit r146 (pengvado)

[Loren Merritt]

On Mon, 28 Feb 2005, Tuukka Toivonen wrote:
> On Mon, 28 Feb 2005, Subversion daemon wrote:
>
> Thanks for applying my fix, and sorry to nitpick but: r145 copied too little 
> data (image width - 32) but now r146 copies too much data into the lowres 
> image, 32 pixels extra, as you doubled the number of lowres pad space. This 
> won't hurt as it comes from the pad space, but is a bit inefficient.
>
> I recommend removing my patch if you want to have 64 pixels pad space also in 
> the low resolution image:

I didn't apply your patch. The lowres image was supposed to have 32 pixels 
of padding on each side (because I didn't want to modify the ME function 
for x264_slicetype_analyse), so it was the allocation that was wrong.
(Of course, I'm not sure that there aren't still bugs.)

--Loren Merritt

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html