[x264-devel] Re: x264_center_filter_mmxext: Use of uninitialised value

[Mathieu Monnier]

Hi again,

Thanks to fenrir's welcomed comments, here is a patch correcting the
infamous x264_center_filter_mmxext function. The .data section has
disappeared, which should hopefully solve compilation issues some were
experiencing, and valgrind doesn't complain anymore.

The issue was in fact a certain bad tendency i had to use esp and
increment it when making the first pass on a row, which made valgrind
progressively mark the temporary buffer as uninitialized.

I tested the modifications against the c version, and results on midly
noised clips and on foreman seem to be identical.

Regards,

Mathieu

PS : for the moderator(s), please drop the previous mail
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: x264_hpel3.patch
Url: http://mailman.videolan.org/pipermail/x264-devel/attachments/20050506/423ff570/attachment.txt