[x264-devel] Re: x264: svn commit r340 (pengvado)

[thetrueavatar thetrueavatar]

A stupid question but you don't have unit testing for preventing such
regression?

2005/11/2, Guillaume POIRIER <poirierg at gmail.com>:
> Hi,
>
> On 11/2/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> > Hi,
> >
> > On 10/26/05, Subversion daemon <svn at videolan.org> wrote:
> > > r340 | pengvado | 2005-10-26 09:04:59 +0200 (Wed, 26 Oct 2005) | 6 lines
> > > Changed paths:
> > >    M /trunk/encoder/encoder.c
> > >    M /trunk/encoder/ratecontrol.c
> > >    M /trunk/vfw/codec.c
> > >    M /trunk/vfw/x264vfw.h
> > >    M /trunk/x264.c
> > >    M /trunk/x264.h
> > >
> > > If frame count is known at init time (cli & vfw), then abort if the 2nd pass
> > > exceeds the length of the 1st pass.
> > > If it's not known (mencoder), then report a non-fatal error when we run off the
> > > end of the 1st pass stats, and switch to constant QP.
> >
> > I suspect this commit broke x264 support in MEncoder. I've not been
> > able to encode 2passes with x264 ever since. I'll do some more
> > investigations.
> >
> > I get this kind of error:
> >
> > x264 [error]: 2nd pass has more frames than 1st pass (374272 vs 214749)
>
> Woops, sorry for the noise: my checkout/build was not up to date
>
> :-(
>
> Works like a charm now.
> --
> Reading doesn't hurt, really!
>  -- Dominik 'Rathann' Mierzejewski
>
> --
> This is the x264-devel mailing-list
> To unsubscribe, go to: http://developers.videolan.org/lists.html
>
>

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html