[x264-devel] Re: [PATCH] Altivec optimizations for quant4x4, quant4x4dc, quant8x8, sub8x8_dct8

[Guillaume Poirier]

Hi,

Loren Merritt wrote:
> On Thu, 24 Aug 2006, Guillaume POIRIER wrote:
> 
>> Last but not least, when I tested that my patch was applying cleanly
>> to svn, I had to remove this hunk:
>>
>> Index: common/macroblock.c
>> ===================================================================
>> --- common/macroblock.c (revision 540)
>> +++ common/macroblock.c (working copy)
>> @@ -26,7 +26,7 @@
>>
>> #include "common.h"
>>
>> -static const int dequant_mf[6][4][4] =
>> +static const int dequant_mf[6][4][4] __attribute__((__aligned__(16))) =
>> {
>>     { {10, 13, 10, 13}, {13, 16, 13, 16}, {10, 13, 10, 13}, {13, 16,
>> 13, 16} },
>>     { {11, 14, 11, 14}, {14, 18, 14, 18}, {11, 14, 11, 14}, {14, 18,
>> 14, 18} },
>>
>>
>> Now x264 in svn doesn't have this line since r552:
>> https://trac.videolan.org/x264/changeset/552
>>
>> I don't know what what happened to this variable, but I need to ensure
>> that it's aligned (as my code assume it).
>> The diff indicates that the declaration of dequant_mf[6][4][4] was
>> just removed, and I can't find where it's declared, though grep does
>> show that it's still used, so I guess there's a declaration somewhere,
>> it's just that _I_ can't locate it.
> 
> 
> dequant_mf isn't used, and should have been removed way back when I
> implemented custom quant matrices. Your grep finds local variables,
> which point into h->quant4_mf or h->quant8_mf. Those are malloced and
> thus aligned.

Right. I checked yesterday night, and I can confim that I didn't need
it :)

Thanks,

Guillaume

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html