[x264-devel] Re: [PATCH] Altivec optimizations for quant4x4, quant4x4dc, quant8x8, sub8x8_dct8

[Guillaume POIRIER]

Evening/Afternoon,

On 8/25/06, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hi,
>
> On 8/25/06, Loren Merritt <lorenm at u.washington.edu> wrote:
> > On Fri, 25 Aug 2006, Guillaume POIRIER wrote:
> >
> > > I'm attaching a further cleanned-up version of my code with the DCT8
> > > routine as a macro.
> > > I had to nuke the comments, which is a bit unfortunate, however the
> > > code is fairly straintforward with regards to the C version, so I
> > > don't think there's too much of a loss of information.
> >
> > Why? The only restriction on comments in macros is that they have to be
> > /**/ and not //, since the whole macro is logically one line.
>
> Ok, I didn't know that. I've only written very straightforward macros up to now.
> I'll post a patch with the comments back on, and the transpose issue

Here is an updated patch that puts back the comments on the macro, and
uses the macro of x264 to do the 8x8 transpose.

More comments welcome, and thanks Loren for your feedback and suggestions.

Guillaume
-- 
A thing is not necessarily true because a man dies for it.
-- Oscar Wilde
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Altivec_quant-dct_routines_3.diff
Type: text/x-patch
Size: 11613 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20060826/ddd17487/attachment.bin