[x264-devel] Re: x264: svn commit r416 (pengvado)

[Jindrich Makovicka]

Subversion daemon wrote:
> r416 | pengvado | 2006-02-06 07:14:04 +0100 (Mon, 06 Feb 2006) | 3 lines
> Changed paths:
>    M /trunk/common/amd64/predict.c
>    M /trunk/common/i386/predict-a.asm
>    M /trunk/common/i386/predict.c
>    M /trunk/common/i386/predict.h
>    M /trunk/common/predict.c
>    M /trunk/tools/checkasm.c
> 
> x86 mmx for some intra pred functions

Hi,

although the code compiles in nasm, the pinsrw mnemonics is wrong - the
second argument should be either r32 or m16.

Index: predict-a.asm
===================================================================
--- predict-a.asm	(revision 426)
+++ predict-a.asm	(working copy)
@@ -91,7 +91,7 @@
     jge         .have_topleft
     mov         al,  [edx]
     mov         ah,  [edx]
-    pinsrw      mm1, ax, 0
+    pinsrw      mm1, eax, 0
     mov         eax, [picesp + 12]
 .have_topleft:

@@ -99,7 +99,7 @@
     jne         .have_topright
     mov         al,  [edx+7]
     mov         ah,  [edx+7]
-    pinsrw      mm2, ax, 3
+    pinsrw      mm2, eax, 3
 .have_topright:

     PRED8x8_LOWPASS mm0, [edx]

Regards,

-- 
Jindrich Makovicka

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html