[x264-devel] Re: bug: static declaration follows non-static declaration

[Marc Schulz]

Kyle Husmann wrote:
> Hi,
> I was trying to compile the latest svn version of x264 with gcc4.  
> However, it errored with:
>
>     x264.c:77: error: static declaration of 'p_open_outfile' follows
>     non-static declaration
>     muxers.h:50: error: previous declaration of 'p_open_outfile' was here
>     x264.c:78: error: static declaration of 'p_set_outfile_param'
>     follows non-static declaration
>     muxers.h:51: error: previous declaration of 'p_set_outfile_param'
>     was here
>     x264.c:79: error: static declaration of 'p_write_nalu' follows
>     non-static declaration
>     muxers.h:52: error: previous declaration of 'p_write_nalu' was here
>     x264.c:80: error: static declaration of 'p_set_eop' follows
>     non-static declaration
>     muxers.h:53: error: previous declaration of 'p_set_eop' was here
>     x264.c:81: error: static declaration of 'p_close_outfile' follows
>     non-static declaration
>     muxers.h:54: error: previous declaration of 'p_close_outfile' was here
>
>
> I have made a patch to fix this.  I don't really know how to program, 
> so I probably violated some coding practices, but it works.  Hopefully 
> someone will fix this the correct way in the next release?
>
> Thanks,
> -Kyle
Kyle,

According to some discussion going on it is also safe to remove allt he 
declarations from muxers.h. They should only need to be declared in x264.c

Marc

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html