[x264-devel] square sar should be allowed

[Loïc Le Loarer]

Hi,

I observe that x264 refuses to write a sar of 1:1 and prefer to let the
"unknown" status. I think this is wrong, an unknown aspect ratio is not
the same of a given 1:1 aspect ratio.

Here is a patch which removes the test and allows to put an explicit
square sar.

Best regards.

-- 
Loïc

"heaven is not a place, it's a feeling"
-------------- next part --------------
Index: encoder/encoder.c
===================================================================
--- encoder/encoder.c	(revision 520)
+++ encoder/encoder.c	(working copy)
@@ -506,10 +506,6 @@
         {
             x264_log( h, X264_LOG_ERROR, "cannot create valid sample aspect ratio\n" );
         }
-        else if( i_w == i_h )
-        {
-            x264_log( h, X264_LOG_INFO, "no need for a SAR\n" );
-        }
         else
         {
             x264_log( h, X264_LOG_INFO, "using SAR=%d/%d\n", i_w, i_h );
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20060510/081efdd4/attachment.pgp