[x264-devel] Re: [PATCH] malloc result test

Loren Merritt lorenm at u.washington.edu
Tue May 30 09:19:22 CEST 2006


On Wed, 24 May 2006, Loïc Le Loarer wrote:

> It seems that x264_malloc result is nearly never tested in allocation
> functions, which could lead to segfaults in some situations.
>
> Here a small patch which adds the correct tests for x264_frame_new
> function with correct unallocation when something goes wrong. If this
> patch is accepted, I'll go on to have this kind of test where necessary.
>
> Best regards.

OK, but it doesn't help unless you check x264_frame_new's return value too 
:)

--Loren Merritt


More information about the x264-devel mailing list