[x264-devel] Re: bug in x264_validate_parameters(...) concerning the "--analyse" argument ?

[Andrew Church]

>	h->param.analyse.inter &=
>X264_ANALYSE_PSUB16x16|X264_ANALYSE_PSUB8x8|X264_ANALYSE_BSUB16x16|
>					  X264_ANALYSE_I4x4|X264_ANALYSE_I8x8;
>	h->param.analyse.intra &= X264_ANALYSE_I4x4|X264_ANALYSE_I8x8;
>	if( !(h->param.analyse.inter & X264_ANALYSE_PSUB16x16) )
>      	h->param.analyse.inter &= ~X264_ANALYSE_PSUB8x8;
>
>Since this part is in encoder.c, I guess it's intentional too but why ?
>What's the purpose of forcing param.analyse.inter to a given value since
>it's supposed to be defined using a command line argument ("--analyse") ?

     That's a mask operation (&=), not an assignment (=).  I'd have to
check to be sure, but presumably the values listed are the only valid flags
for those variables, so the code is masking off all the other (invalid)
bits.

  --Andrew Church
    achurch at achurch.org
    http://achurch.org/

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html