[x264-devel] Re: bug in x264_validate_parameters(...) concerning the "--analyse" argument ?

[Mathieu Monnier]

 > What's the purpose of line 447 which enables X264_ANALYSE_PSUB8x8 (using
 > "....|X264_ANALYSE_PSUB8x8|....") if, on line 450, the condition is 
always
 > true and so, on line 451, X264_ANALYSE_PSUB8x8 is disabled ?

line 447 doesn't enable PSUB8x8, it makes a binary "and" ( &= ) on the 
flags, in order to restrict a possibly random value ( since it was given 
by an user ) to a valid value for the encoder.
line 450 disables PSUB8x8 ( &=~ ) if and only if PSUB16x16 wasn't used ( 
!& ). That is, I guess, a restriction of the me algorithm. Then again, 
it's not always disabled, since if PSUB16x16 was enabled, PSUB8x8 will 
be left intact.

Regards,

Mathieu

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html