[x264-devel] Re: [PATCH] IDCT8 and SA8D routines in Altivec

[Guillaume Poirier]

Hi,

Loren Merritt wrote:
>
> No complaints about the content, just cosmetics.
> 
> inconsistent indentation:
> 
> +    vec_s16_t b0v = vec_add(a0v, a2v); \
> +    /* int    b2  =         a0 - a2; */\
> +   vec_s16_t  b2v = vec_sub(a0v, a2v); \
> +    /* int    b1  =         a1 + a3; */\
> +    vec_s16_t b1v = vec_add(a1v, a3v); \
> 
> +    vec_s16_t diff0v, diff1v, diff2v, diff3v,
> +        diff4v, diff5v, diff6v, diff7v;
> 
> +    vec_s16_t sa8d0v, sa8d1v, sa8d2v, sa8d3v,
> +        sa8d4v, sa8d5v, sa8d6v, sa8d7v;
> 
> and some functions have cuddled braces while others have the open brace
> on its own line.

All fixed in attached patch, which is what will get to the repository
tonight as you don't seem to object ^^

Guillaume
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: idct8+sa8d.2.diff
Url: http://mailman.videolan.org/pipermail/x264-devel/attachments/20061127/a0f27016/attachment.txt