[x264-devel] Re: [PATCH] IDCT8 and SA8D routines in Altivec

[Guillaume POIRIER]

Hi,

On 11/27/06, Guillaume Poirier <gpoirier at mplayerhq.hu> wrote:
> Hi,
>
> Loren Merritt wrote:
> >
> > No complaints about the content, just cosmetics.
> >
> > inconsistent indentation:
> >
> > +    vec_s16_t b0v = vec_add(a0v, a2v); \
> > +    /* int    b2  =         a0 - a2; */\
> > +   vec_s16_t  b2v = vec_sub(a0v, a2v); \
> > +    /* int    b1  =         a1 + a3; */\
> > +    vec_s16_t b1v = vec_add(a1v, a3v); \
> >
> > +    vec_s16_t diff0v, diff1v, diff2v, diff3v,
> > +        diff4v, diff5v, diff6v, diff7v;
> >
> > +    vec_s16_t sa8d0v, sa8d1v, sa8d2v, sa8d3v,
> > +        sa8d4v, sa8d5v, sa8d6v, sa8d7v;
> >
> > and some functions have cuddled braces while others have the open brace
> > on its own line.
>
> All fixed in attached patch, which is what will get to the repository
> tonight as you don't seem to object ^^

Patch applied, minus the configure part that wasn't meant to be there.

Guillaume
-- 
An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)
http://www.brainyquote.com/quotes/quotes/t/thomasjeff157207.html

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html