[x264-devel] Re: [PATCH] Altivec optimizations for quant4x4, quant4x4dc, quant8x8, sub8x8_dct8, sub16x16_dct8, pixel_sa8d_8x8

[Loren Merritt]

On Wed, 6 Sep 2006, Guillaume POIRIER wrote:
>
> Another day, another revision of my patchset. In today's menu:
> improved all quant routines to yet again shave off a couple of
> percents of CPU cycles, and some more GCC3.3 fixes.
>
> Get it while it's hot, and please test && review,

> +#ifdef ARCH_PPC
> +if( cpu&X264_CPU_ALTIVEC )
> +{
> +    /* determine the biggest coeffient in all quant8_mf tables */
> +    for( i = 0; i < 2*6*8*8; i++ )
> +    {
> +        int q = h->quant8_mf[0][0][0][i];
> +        if( maxQ8 < q )
> +            maxQ8 = q;
> +    }
[...]

Duplicate code. Just move the first copy out of if(mmx).

> +static const int def_quant4_mf[6][4][4] __attribute__((__aligned__(16))) =

DECLARE_ALIGNED. yes, it works with assignments too.

--Loren Merritt

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html