[x264-devel] Re: [PATCH] Align dct arrays (Altivec optimization, step 0)

[Guillaume POIRIER]

Hi,

Guillaume POIRIER a écrit :
> Hello folks,
> In order to reduce the size of my Altivec optimizations patchset, here's 
> a patch that just forces the alignment of dct arrays found in 
> encoder/macroblock.c

[..]

Ahem...

> Index: common/i386/pixel-sse2.asm
> ===================================================================
> --- common/i386/pixel-sse2.asm	(révision 564)
> +++ common/i386/pixel-sse2.asm	(copie de travail)
> @@ -758,11 +758,11 @@
>      mov      edx,  [esp+12]
>      picpush  ebx
>      picgetgot ebx
> -    movdqa   xmm0, [eax+ 0]
> -    movdqa   xmm1, [eax+16]
> -    movdqa   xmm2, [eax+32]
> -    movdqa   xmm3, [eax+48]
> -    movdqa   xmm4, [eax+64]
> +    movdqu   xmm0, [eax+ 0]
> +    movdqu   xmm1, [eax+16]
> +    movdqu   xmm2, [eax+32]
> +    movdqu   xmm3, [eax+48]
> +    movdqu   xmm4, [eax+64]
>      paddd    xmm0, [ecx+ 0]
>      paddd    xmm1, [ecx+16]
>      paddd    xmm2, [ecx+32]

Off course, this hunk wasn't supposed to be there. Fixed in attached 
patch...

Guillaume
-------------- next part --------------
A non-text attachment was scrubbed...
Name: align_tabs.1.diff
Type: text/x-patch
Size: 4493 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20060916/60e68364/attachment.bin