[x264-devel] [PATCH] repairing MSVC build

Vincent Torri vtorri at univ-evry.fr
Mon Aug 20 19:39:51 CEST 2007


WIN32 can be not defined. For example with gcc and the -ansi option

use _WIN32 or __WIN32__

see : http://article.gmane.org/gmane.comp.gnu.mingw.user/23401

regards

Vincent Torri

On Mon, 20 Aug 2007, Alex wrote:

> Hi.
> They all should be WIN32. because WIN32 in defined in the preprocessor
> option of the VC project. I will submit a patch after I do some
> testing.
>
> On 8/20/07, Loren Merritt <lorenm at u.washington.edu> wrote:
>> On Mon, 20 Aug 2007, Gabriel Bouvigne wrote:
>>
>>> This is a trivial change in order to un-break MSVC build. (broken since the
>>> zone update)
>>>
>>> -#ifdef __WIN32__
>>> +#if defined (__WIN32__) || defined(_MSC_VER)
>>
>> Is __WIN32__ not defined? Then that's what should be fixed.
>> I see WIN32, _WIN32, and __WIN32__ at various places. Which one is
>> correct?
>>
>> --Loren Merritt
>> _______________________________________________
>> x264-devel mailing list
>> x264-devel at videolan.org
>> http://mailman.videolan.org/listinfo/x264-devel
>>
> _______________________________________________
> x264-devel mailing list
> x264-devel at videolan.org
> http://mailman.videolan.org/listinfo/x264-devel
>
> -- 
> Ce message a été vérifié par MailScanner
> pour des virus ou des polluriels et rien de
> suspect n'a été trouvé.
> Message délivré par le serveur de messagerie de l'Université d'Evry.
>
>
-------------- next part --------------
_______________________________________________
x264-devel mailing list
x264-devel at videolan.org
http://mailman.videolan.org/listinfo/x264-devel


More information about the x264-devel mailing list