[x264-devel] Re: [PATCH] move x264_levels extern from x264.h to set.h

[Limin Wang]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

* Loren Merritt <lorenm at u.washington.edu> [2007-01-31 20:10:59 -0700]:

> On Thu, 1 Feb 2007, Limin Wang wrote:
> 
> >I think x264_levels[] is used by x264 library internally and shouldn't
> >be exposed out to public interface. Is it true?
> 
> I don't know of any applications that use x264_levels[], but I think it 
> should be part of the API. Because selecting a level is only informative, 
> it doesn't modify all the other settings to be compliant with the level. 
> (And x264 can't do the enforcement, because levels limit some things 
> like resolution and framerate that x264 can't change.)
> So if an application wants to do the levels configuration rather than pass 
> it on to the user, it needs to access the table of constraints.

If it's part of the API, then it's necessary to add x264_get_levels()
API instead of extern directly, for application have no way see the
real content of internal  x264_levels[].


> --Loren Merritt
> 
> -- 
> This is the x264-devel mailing-list
> To unsubscribe, go to: http://developers.videolan.org/lists.html
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRcFxOUztbf7dKiuoAQLZNQgAjlD4VbDzuOQiXQDGavlCJ16q7u//mt6h
fSOLWBjIu5C+f6/E8pGXEJp8F9/l18cRnSO5strQLaauD2rLYWYTzo/0Z9Ij1GC6
ooMcq2gWOL+VjaxOF4/ZCaD1CUTZDlpNgbdbqWt2rDed/nQ2DFGitVRzaark4Adz
F0QB6d+SDqJN5kRUdO4UVn7woFFtXmkJUplT+e1KvNvTZFfjUxQA0iunlxZrNDnE
Jpq78LLBmV0vp1Utwy70A0/5In8SEYk5L4ZnngnmVc9aFza7CGSc14VVk5J/Ztc+
gWz3xMtxZ38TJA5C0XEYNsvqxYtRaxMZL+Rx4wvergwCKOKRCaAoRQ==
=WE1E
-----END PGP SIGNATURE-----

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html