[x264-devel] Re: [PATCH] fix the compiler warning

[Limin Wang]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Loren,

> (a) wrong, it would be
>   if( !array_int16_non_zero( (int16_t*)dct2x2, 
>   sizeof(dct2x2)/sizeof(int16_t) ))
Yes, good catch.

> 
> (b) I'm not willing to add code just to shut up a gcc warning. If it's 
> that important, I'll make array_non_zero take a void* instead of separate 
> versions per type.
Yes, the complete fix is to use void* in the interface.

By the way, what's meaning of array_non_zero? It'll check all array or instead
of one non-zero of the array. If the array[0] is non zero and array[1] is
zero, it'll return 1 still, right?


Thank,
Limin

> --Loren Merritt
> 
> -- 
> This is the x264-devel mailing-list
> To unsubscribe, go to: http://developers.videolan.org/lists.html
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRaXNXEztbf7dKiuoAQIjpwf+IRrq+Fx7wxJ26Pkh036gciR7QLTpNwqm
o2l2yu+v0P2uSe0e7UNeTFc3LtRC7vw7rx9zoDqn9fJ53AWGlxS0xSvEDzMwj/3C
TBt30nhD1sb5egwHY9VP4CzW66bG6y7/PxIspcXYrTVKMdUzz5p6xxqb//DV9d29
8JB3kQaynjcrfmJpgjHioLA41rgtxm8RNDg0Um4axfZyLf8q5ECAL3FgHDcSb+Rh
0rOtjdKGQMlb1BbvxeQkMRdZihXKw+mNcGqQd2AnsRoGQ8NzlOBqiIdQOwU1A/po
TSHqJ5O7/0R7cbStwUdarlH5THnxWuroJY/BtLFDVzbQ3bVoZj2GYg==
=YqmW
-----END PGP SIGNATURE-----

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html