[x264-devel] Re: [Griffith Rees <griff.rees at gmail.com>] Re: Re: Problems compiling xubuntu ppc

[Guillaume POIRIER]

Hi,

On 1/21/07, Griffith Rees <griff.rees at gmail.com> wrote:
> Well, I don't know what else to say than thank you, and please let me know
> if there's any more help I can provide.

Attached patch should allow you to go further in compilation process,
but since I haven't addressed all issues yet, it won't completely
compile.

If all goes "well", you should terminate compilation with this error
(which is normal):

gcc-4.1.1 -O4 -ffast-math  -Wall -I. -D__X264__ -DHAVE_MALLOC_H
-maltivec -mabi=altivec -DARCH_PPC -DSYS_LINUX -DHAVE_PTHREAD -s
-fomit-frame-pointer   -c -o common/ppc/dct.o common/ppc/dct.c
common/ppc/dct.c: In function 'x264_add8x8_idct8_altivec':
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:331: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:339: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:348: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:349: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:350: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:351: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:352: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:353: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:354: error: invalid parameter combination for AltiVec intrinsic
common/ppc/dct.c:355: error: invalid parameter combination for AltiVec intrinsic
make: *** [common/ppc/dct.o] Error 1

I'm mainly posting this patch to know if such patch meets x264's
quality standards.
I think it's ok, but I prefer to ask.

BTW, this bug report clearly shows that x264's user base on Linux is
very, very thin as this code has been on x264's svn for several weeks.


Guillaume
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linux-cleanup.diff
Type: application/octet-stream
Size: 3398 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20070123/cdc49023/attachment.obj