[x264-devel] Re: [PATCH] add pps_id option and define sps_id and pps_id as uint8_t

[Loren Merritt]

On Wed, 31 Jan 2007, Limin Wang wrote:

> The patch try to allow user configure sps_id and pps_id with different value.
> In addition, by the specs, sps_id range is from 0 to 31, pps range is from
> 0 to 255, so replace int with uint8_t type. Please review it.

Just because the range happens to be 0..255 is no reason to use uint8_t 
over int, it's a reason to explicitly boundscheck.
And unless you can provide a reason to do otherwise, I'll just restrict 
the range to 0..31 and continue using one parameter for both ids.

--Loren Merritt

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html