[x264-devel] [PATCH] disable bframe adaptive can't work

[Gabriel Bouvigne]

Limin Wang a écrit :

>> That's because you locked b-frames adaptation only for subsequent 
>> frames. The first B frame insertion is still adaptive. Have a look at 
>> slicetype.c, lines 404-414, you will see 2 potential jumps to no_b_frames.
> 
> Yes, at beginning, I disable the two place also, but by the test, it'll cause
> scenecut detection can't work as expected. So haven't check adaption in the
> first two place, I feel it's for scenecut detection. Haven't understand the
> whole logic yet.

x264 is first checking for potential B frame. If it decides to reject B 
frame, then and only then it checks for a potential scenecut. (I 
personnaly think that the goto/label is reducing ease of understanding a 
bit).
In your case, you would want to disable adaptive b frames, but still 
pass trough the lines 395-400 part.
_______________________________________________
x264-devel mailing list
x264-devel at videolan.org
http://mailman.videolan.org/listinfo/x264-devel