[x264-devel] Re: [PATCH] large files support for MSVC

[Loren Merritt]

On Tue, 12 Jun 2007, Gabriel Bouvigne wrote:

> BTW, would you object to have a config_ms.h file that would replace the 
> generated config.h in case of MSVC?
>
> It would allow a central place for compiler specific defines, and would be 
> the place to define features that we want to use (like HAVE_PTHREAD or the 
> likes). (that is the way we are using within Lame)

ok. However, "central place for compiler specific defines" and "define 
features that we want to use" would not necessarily be the same file. The 
former should contain all compiler specific stuff, not just MSVC, and 
should be called osdep.h or something.
If you expect anyone to ever change the features enabled in the MSVC 
build, it should have a separate config_ms.h to make up for being unable 
to run configure. If that stuff won't ever change then it can go in 
osdep.h too.

--Loren Merritt

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html