[x264-devel] Re: x264: svn commit r629 (sam)

[Guillaume POIRIER]

Hi,

On 3/14/07, Subversion daemon <svn at videolan.org> wrote:
> r629 | sam | 2007-03-14 19:04:06 +0100 (Wed, 14 Mar 2007) | 4 lines
> Changed paths:
>    M /trunk/Makefile
>    M /trunk/common/cpu.c
>    M /trunk/configure
>
>   * common/cpu.c: runtime AltiVec autodetection on Linux.
>   * configure, Makefile: do not build the whole project with -maltivec because
>     it generates AltiVec code in weird places.
>
>  > http://trac.videolan.org/x264/changeset/629

Thanks for doing this, but this breaks compilation both on OSX and Linux:

Linux:
gcc -O4 -ffast-math  -Wall -I. -D__X264__ -DHAVE_MALLOC_H -DARCH_PPC
-DSYS_LINUX -DHAVE_PTHREAD -s -fomit-frame-pointer   -c -o
common/quant.o common/quant.c
In file included from common/ppc/quant.h:22,
                 from common/quant.c:29:
/usr/lib/gcc/powerpc-linux-gnu/4.1.2/include/altivec.h:37:2: error:
#error Use the "-maltivec" flag to enable PowerPC AltiVec support
In file included from common/quant.c:29:
common/ppc/quant.h:30: error: expected specifier-qualifier-list before
'__vector'
common/ppc/quant.h:35: error: expected specifier-qualifier-list before
'__vector'
make: *** [common/quant.o] Error 1


OSX:

gcc -O4 -ffast-math  -Wall -I. -D__X264__ -falign-loops=16 -DARCH_PPC
-DSYS_MACOSX -DHAVE_PTHREAD -s -fomit-frame-pointer   -c -o
common/quant.o common/quant.c
In file included from common/quant.c:29:
common/ppc/quant.h:30: error: parse error before 'vector'
common/ppc/quant.h:30: warning: no semicolon at end of struct or union
common/ppc/quant.h:31: warning: type defaults to 'int' in declaration
of 'vect_int_u'
common/ppc/quant.h:31: warning: data definition has no type or storage class
common/ppc/quant.h:35: error: parse error before 'vector'
common/ppc/quant.h:35: warning: no semicolon at end of struct or union
common/ppc/quant.h:36: warning: type defaults to 'int' in declaration
of 'vect_ushort_u'
common/ppc/quant.h:36: warning: data definition has no type or storage class
make: *** [common/quant.o] Error 1


Was that patch tested?
I guess a header reorder should fix the problem though. I'll see what I can do.

Guillaume

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html