[x264-devel] Build issue

[Chang Chen]

Thanks 

Could you check it in depot?

Chang 

-----Original Message-----
From: x264-devel-bounces at videolan.org
[mailto:x264-devel-bounces at videolan.org] On Behalf Of Paul -Spawn-
Rysevets
Sent: Monday, April 21, 2008 4:42 PM
To: Mailing list for x264 developers
Subject: Re: [x264-devel] Build issue

Hello Chang,

Monday, April 21, 2008, 11:06:30 AM, you wrote:

CC> See the old codes, I think adding cast from void* to uint8_t* would
be ok.
CC> Would you like submitting your MSVS2005 project?
CC> Chang

sure, why not...
http://rapidshare.com/files/109187350/x264.r821.modified.src.rar
but, the difference is only in those two lines..

and my code has
x264.gaussian.cplxblur.01.diff  <--- this one is also modified...
x264_me-prepass_DeathTheSheep.01.diff
x264_2pass_vbv.7.diff
x264_hrd_pulldown.04_interlace.diff
- HRD and pulldown for HD compatibility, updated patch for interlacing

--------------[EVERYTHING OLD]----------------------------
CC> and what about this solution?
CC>  
CC> -        CHECKED_MALLOC( frame->buffer[4+i],
CC> -                        frame->i_stride[0] * ( frame->i_lines[0] +
2*i_padv ) );
-        frame->>filtered[i+1] = ((uint8_t*)frame->buffer[4+i]) +
CC> -                                frame->i_stride[0] * i_padv + PADH;
CC> +        CHECKED_MALLOC( frame->buffer[i], luma_plane_size/4 );
+        frame->>plane[i] = (uint8_t*)frame->buffer[i] +
(frame->i_stride[i] * i_padv + PADH)/2;
CC>      }
CC> +    /* all 4 luma planes allocated together, since the cacheline
split code
CC> +     * requires them to be in-phase wrt cacheline alignment. */
CC> +    CHECKED_MALLOC( frame->buffer[0], 4*luma_plane_size);
CC> +    for( i = 0; i < 4; i++ )
+        frame->>filtered[i] = (uint8_t*)frame->buffer[0] +
i*luma_plane_size + frame->i_stride[0] * i_padv + PADH;
+    frame->>plane[0] = frame->filtered[0];
CC>  
CC> in this case MSVS2005 says it's fine... and compiles it
CC> perfectly. (i've wrote that on doom9 last week)
CC> This line would be problematic,
CC>  
frame->>plane[i] = frame->buffer[i] + (frame->i_stride[i] * i_padv +
PADH)/2;
CC>  
CC> the buffer array is defined as "void    *buffer[4];" and plane is
CC> defined as "uint8_t *plane[3]", so it leads a compile issue at
MSVC71


-- 
Best regards,
 Paul 'Spawn' Rysevets          P.Rysevets at sam-solutions.net
 SpAwN_gUy.aka.WAREZMasta       WAREZMasta at gmail.com
 ICQ(PRiMARY):968978            ICQ(Secondary):169588436

_______________________________________________
x264-devel mailing list
x264-devel at videolan.org
http://mailman.videolan.org/listinfo/x264-devel