[x264-devel] clean of all warnings when -Wmissing-prototypes is enabled

Loic Le Loarer lll+vlc at m4x.org
Sun Aug 3 20:09:24 CEST 2008


Hi,

It seems that many people are in vacation this week on this list, anyway, I
have started learning how to use git with the help of the great
http://wiki.videolan.org/Git page, and so I send the rest of my patches using
git-send-email.

The goal of these patches (and my 3 previous ones) is to fix all the warnings
generated when x264 is compiled with -Wmissing-prototypes (and gcc 4.1). I
think all the fixes are important (except may be the void argument), because
either they fix missing static declaration which help gcc optimization (or at
least should), or they fix case where the implementation of the function isn't
checked against the declaration, which can lead to real bugs uncatched at
compile time if the prototype isn't changed everywhere.

Do you think those patches are useful and can be included in mainline ?

Best regards
-- 
Loïc Le Loarer


More information about the x264-devel mailing list