[x264-devel] Possible problem in configure script

[Guillaume POIRIER]

Hello,

2008/8/25 Markus Kanet <darkvision at gmx.eu>
>
> Hi...
>
> in commit 9d4d168bb484c2a27e9f4b8f5eb360a00a1cf426 "improve generation of Darwin libraries" seem to be a small typo. Here is the intresting part of that commit:
>
> +        if [ "$SYS" = "MACOSX" ]; then
> +            echo "SOSUFFIX=dylib" >> gtk/config.mak
> +            echo "SONAMEGTK=libx264gtk.$API.dylib" >> gtk/config.mak
> +            echo 'SOFLAGS=-dynamiclib -Wl,-single_module -Wl,-read_only_relocs,suppress -install_name $(DESTDIR)$(libdir)/$(SONAMEGTK)' >> gtk/config.mak
> +        else
> +            echo "SOSUFFIX=so" >> gtk/config.mak
> +            echo "SONAMEGTK=libx264gtk.so.$API" >> gtk/config.mak
> +            echo 'SOFLAGS=-Wl,-soname,$(SONAME)' >> gtk/config.mak
> +        fi
>
> When the system is not MACOSX then the SOFLAGS for GTK are defined as:
>  echo 'SOFLAGS=-Wl,-soname,$(SONAME)' >> gtk/config.mak
>
> While i'm sure it should be
>  echo 'SOFLAGS=-Wl,-soname,$(SONAMEGTK)' >> gtk/config.mak
>
> Attached is a patch to correct SOFLAGS for GTK.

Thanks, patch applied.

Guillaume
--
One should not give up hope on imbeciles. With a little training, you
can make them into soldiers.
-- Pierre Desproges