[x264-devel] MSVC strtok_r/native zones support

kemuri-_9 kemuri9 at gmail.com
Thu Dec 11 23:33:25 CET 2008


I am putting forth an extremely short patch, which has an overall effect of
+1 lines to have zones work natively in MSVC.

as x264 already requires MSVC 2005 (VC8) all ready for variadic macro
support, this will not have an effect on current compatibility,
as the proposed patch also starts working with 2005.

the patch defines strtok_r as the msvc equivalent of strtok_s, which has the
same exact method signature outside of the names.
it also fixes a memory allocation in the zone parser which causes a seg
fault on non malloc.h systems, which is also required for msvc.


and as a small note to BugMaster on his win x64 workings:
./configure --host=x86_64-pc-mingw32 --disable-avis-input --disable-asm
can generate a working win x64 version of x264 w/ mingw-w64
(I've been using the mingw-w64-bin_i686-mingw_DATE.zip versions)

use the following you want to configure a compileable version without
--disable-asm to work on the win x64 asm
http://kemuri9.net/dev/x264/patches/x264_config_win_x64_asm.diff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.videolan.org/pipermail/x264-devel/attachments/20081211/2e15789b/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264_msvc_zones_fix.diff
Type: application/force-download
Size: 827 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20081211/2e15789b/attachment.bin 


More information about the x264-devel mailing list